This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
feat: add resize feature supports for image and iframe #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/feature
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ruibaby
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
/cc @halo-sigs/halo |
|
|
可以在后续优化，这个可能得修改稍微底层点的东西。 |
|
这里有部分图标（居中和居右）没有显示出来。
|
|
从最新的预览链接，似乎没有找到添加图片和 iframe 的入口。
|
图片的入口目前是在 Console 加的，因为要和附件库绑定。 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot bot
pushed a commit
to halo-dev/console
that referenced
this pull request
Jan 31, 2023
…media (#834) #### What type of PR is this? /kind feature #### What this PR does / why we need it: 升级默认编辑器版本，改动请查阅： 1. halo-sigs/richtext-editor#4 2. halo-sigs/richtext-editor#3 3. halo-sigs/richtext-editor#2 #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note 升级 Console 端默认编辑器版本，以支持图片位置和大小设置、插入音视频等功能。 ```
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…media (halo-dev/console#834) #### What type of PR is this? /kind feature #### What this PR does / why we need it: 升级默认编辑器版本，改动请查阅： 1. halo-sigs/richtext-editor#4 2. halo-sigs/richtext-editor#3 3. halo-sigs/richtext-editor#2 #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note 升级 Console 端默认编辑器版本，以支持图片位置和大小设置、插入音视频等功能。 ```
This was referenced Apr 27, 2023
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
PR from #8 Revert the changes made in #2. Avoid conflicts with manual size setting caused by immediate triggering after binding by checking the number of ResizeObserver events triggered. Remove the transition of the Image component (or at least remove the width and height) to avoid the blocking feeling caused by resizing. **This PR has changed the example-package.json,But the pack lock file was not submitted.(I have an inconsistent version of PNPM)** Fixes #8 ```release-note 支持拖拽调整图片大小。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
Fixes halo-dev/halo#2986
Fixes halo-dev/halo#2985
Fixes halo-dev/halo#2686
Fixes halo-dev/halo#2685
todo list:
测试方式：