Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

chore: bump @halo-dev/richtext-editor to supports more feature about media #834

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 31, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

升级默认编辑器版本,改动请查阅:

  1. feat: add supports for video and audio halo-sigs/richtext-editor#4
  2. feat: add supports for set link halo-sigs/richtext-editor#3
  3. feat: add resize feature supports for image and iframe halo-sigs/richtext-editor#2

Special notes for your reviewer:

Does this PR introduce a user-facing change?

升级 Console 端默认编辑器版本,以支持图片位置和大小设置、插入音视频等功能。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 31, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wzrove January 31, 2023 14:02
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit d51713e into halo-dev:main Jan 31, 2023
@ruibaby ruibaby deleted the chore/richtext-version branch February 1, 2023 02:58
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…media (halo-dev/console#834)

#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

升级默认编辑器版本,改动请查阅:

1. halo-sigs/richtext-editor#4
2. halo-sigs/richtext-editor#3
3. halo-sigs/richtext-editor#2

#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?

```release-note
升级 Console 端默认编辑器版本,以支持图片位置和大小设置、插入音视频等功能。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants