Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在编辑文章页面上传附件时，zip 文件无法正确生成访问链接 #3408

Closed
LIlGG opened this issue Feb 27, 2023 · 2 comments · Fixed by halo-dev/console#893
Closed

在编辑文章页面上传附件时，zip 文件无法正确生成访问链接 #3408

LIlGG opened this issue Feb 27, 2023 · 2 comments · Fixed by halo-dev/console#893
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.3.0

Comments

@LIlGG
Copy link
Member

LIlGG commented Feb 27, 2023

是什么版本出现了此问题？

2.3.0-rc.1

使用的什么数据库？

PostgreSQL

使用的哪种方式部署？

Docker Compose

在线站点地址

No response

发生了什么？

  1. 在编辑文章页面，使用附件上传功能上传 zip 文件，并添加至文章内。
  2. 发现 zip 相关文件的访问链接拼接不正确。

目前测试发现非 zip 类型文件均可正常访问链接，且查看附件管理页面，附件是正常生成了原始链接。

附件内正常生成了链接：
image

文章页面截图：
image

相关日志输出

No response

附加信息

No response
@LIlGG
Copy link
Member Author

LIlGG commented Feb 27, 2023

/kind bug
/milestone 2.3.x
/area console

@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.x milestone Feb 27, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Feb 27, 2023
@ruibaby
Copy link
Member

ruibaby commented Feb 27, 2023

/assign

@ruibaby ruibaby mentioned this issue Feb 27, 2023
Merged
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Feb 28, 2023
@ruibaby
fix: get the wrong link after selecting an attachment (#893)
3d718b5 
#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复默认编辑器从附件库选择非图片、音视频的附件，以链接的形式插入之后得到的链接不正确的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#3408

#### Screenshots:

before:

<img width="995" alt="image" src="https://user-images.githubusercontent.com/21301288/221510856-76eaa125-c13e-472a-8073-7f9f58bb4bd2.png">

after:

<img width="924" alt="image" src="https://user-images.githubusercontent.com/21301288/221510749-c27fc083-3978-4139-959a-426499016d12.png">


#### Special notes for your reviewer:

测试方式：

1. 上传若干 zip 格式附件。
2. 在编辑器中选择这些附件并插入，检查链接是否正确。

#### Does this PR introduce a user-facing change?

```release-note
None
```
@JohnNiang JohnNiang modified the milestones: 2.3.x, 2.3.0 Feb 28, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@ruibaby
fix: get the wrong link after selecting an attachment (halo-dev/conso…
ca0c0b8 
…le#893)

#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复默认编辑器从附件库选择非图片、音视频的附件，以链接的形式插入之后得到的链接不正确的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3408

#### Screenshots:

before:

<img width="995" alt="image" src="https://user-images.githubusercontent.com/21301288/221510856-76eaa125-c13e-472a-8073-7f9f58bb4bd2.png">

after:

<img width="924" alt="image" src="https://user-images.githubusercontent.com/21301288/221510749-c27fc083-3978-4139-959a-426499016d12.png">


#### Special notes for your reviewer:

测试方式：

1. 上传若干 zip 格式附件。
2. 在编辑器中选择这些附件并插入，检查链接是否正确。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

fix: get the wrong link after selecting an attachment ruibaby/halo-console
3 participants
@JohnNiang @ruibaby @LIlGG