This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
fix: get the wrong link after selecting an attachment #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note-none
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/lgtm
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…le#893) #### What type of PR is this? /kind bug #### What this PR does / why we need it: 修复默认编辑器从附件库选择非图片、音视频的附件，以链接的形式插入之后得到的链接不正确的问题。 #### Which issue(s) this PR fixes: Fixes halo-dev#3408 #### Screenshots: before: <img width="995" alt="image" src="https://user-images.githubusercontent.com/21301288/221510856-76eaa125-c13e-472a-8073-7f9f58bb4bd2.png"> after: <img width="924" alt="image" src="https://user-images.githubusercontent.com/21301288/221510749-c27fc083-3978-4139-959a-426499016d12.png"> #### Special notes for your reviewer: 测试方式： 1. 上传若干 zip 格式附件。 2. 在编辑器中选择这些附件并插入，检查链接是否正确。 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
修复默认编辑器从附件库选择非图片、音视频的附件，以链接的形式插入之后得到的链接不正确的问题。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3408
Screenshots:
before:
after:
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?