Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] Update IP Fee pricing for February 2024 price increase #14190

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jigold
Copy link
Contributor

@jigold jigold commented Jan 22, 2024

Fixes #13784

Here's the GCP documentation:
https://cloud.google.com/vpc/pricing-announce-external-ips

We were previously billing the same IP-Fee for both spot and regular instances. I changed it so we're billing for each instance type accordingly.

Following #13542, I hard coded the new resource rates.

Copy link
Contributor

@daniel-goldstein daniel-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, merge at your leisure.

@jigold jigold removed the WIP label Feb 1, 2024
@danking danking merged commit 171b39d into hail-is:main Feb 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[batch] new networking prices arrive in GCP on February 1 2024
3 participants