[batch] introduce Support-Logs-Specs-and-Firewall fee #13542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jigold not actually WIP, but I want control over when it merges. Ready for review. |
jigold
previously requested changes
Sep 1, 2023
| @@ -151,6 +153,7 @@ def from_dict(data: dict) -> 'GCPSlimInstanceConfig': | |||
| GCPDynamicSizedDiskResource('disk/pd-ssd/1'), | |||
| GCPIPFeeResource('service-fee/1'), | |||
| GCPServiceFeeResource('ip-fee/1024/1'), | |||
| GCPSupportLogsSpecsAndFirewallFees('gcp-support-logs-specs-and-firewall-fees/1'), | |||
There was a problem hiding this comment.
I don't think you need this as it's for backwards compatibility. See comment in #13539.
There was a problem hiding this comment.
Can you elaborate on what kind of backwards compatibility? Should we remove this branch entirely?
There was a problem hiding this comment.
I think we can. It was for when the instance_config field was not in the database for old entries, so their value is NULL. We knew what the config should be at the time though. The only reason we'd need this code path is if we wanted to compute resources for old instances. I don't know why we would want to do that.
danking
force-pushed
the
support-logs-firewall-fees
branch
from
4b19eba
to
fe59a49
Compare
added 5 commits
September 14, 2023 17:14
jigold
approved these changes
Sep 22, 2023
danking
pushed a commit
that referenced
this pull request
Feb 1, 2024
Fixes #13784 Here's the GCP documentation: https://cloud.google.com/vpc/pricing-announce-external-ips We were previously billing the same IP-Fee for both spot and regular instances. I changed it so we're billing for each instance type accordingly. Following #13542, I hard coded the new resource rates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13526
I verified I got the right number. I didn't import since I think we decided we shouldn't rely on the code base in the migrations.