[query] skip comments when parsing spark-defaults.conf #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge until addressing concerns raised by Chris in the release thread of #team |
danking
force-pushed
the
fix-requester-pays-spark-conf-parser
branch
from
79d0c0d
to
f96b7b8
Compare
daniel-goldstein
approved these changes
Jun 12, 2023
daniel-goldstein
approved these changes
Jun 12, 2023
chrisvittal
approved these changes
Jun 12, 2023
|
Wrong zstd change, that one is good, and is about supporting newer bgen versions. |
|
Ah, ok, I will revert |
daniel-goldstein
force-pushed
the
fix-requester-pays-spark-conf-parser
branch
from
b50ad38
to
34a4f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.