Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs formatting, some list reordering #232

Closed
wants to merge 3 commits into from
Closed

Docs formatting, some list reordering #232

wants to merge 3 commits into from

Conversation

petecooper
Copy link
Contributor

Docs formatting and presentation to max 80 characters with no widowed words.

No new code, no removals. Some minor reordering on config arrays (e.g. media types) to be alphabetical, but only where it's clear they want to be alphabetical.

No code changes, some config reordering.
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of work! Huge thanks @petecooper! 👍

Few comments, see inline.

Also, your PR needs a rebase but I will handle it before merging.

conf.d/.default.conf Show resolved Hide resolved
conf.d/no-ssl.default.conf Outdated Show resolved Hide resolved
h5bp/ssl/policy_modern.conf Outdated Show resolved Hide resolved
mime.types Show resolved Hide resolved
@petecooper
Copy link
Contributor Author

@LeoColomb - thank you for the review, I appreciate it! The issues you mentioned have been resolved, please advise if anything else needs to be rectified. If you are able to rebase, that would be helpful - I have not done that on a high profile repo before.

LeoColomb pushed a commit that referenced this pull request May 15, 2019
No code changes, some config reordering
@LeoColomb
Copy link
Member

Merged as 67c54c5.

@LeoColomb LeoColomb closed this May 15, 2019
memuller added a commit to memuller/nginx-config that referenced this pull request Aug 26, 2019
* 'master' of github.com:h5bp/server-configs-nginx: (92 commits)
  Additional compression method added for gzip (h5bp#236)
  Bump server-config-test to 1.2.1
  Switch tertiary DNS used for OCSP checking to OpenDNS (h5bp#235)
  Revert "Drop Cache-Control: no-transform usage"
  Release v3.1.0
  Fix CHANGELOG formatting
  Use generic `$host` instead of host name
  Pre-compressed content usage config files
  Fix rebase artifacts
  Documentation formatting and reviewing (h5bp#232)
  Fix 304 responses Cache-control override
  Fix dropped Cache-Control: no-transform usage for SVGZ Compression
  Bump server-configs-test to v1.1.0
  Improve wording and file headers
  Drop Cache-Control: no-transform usage
  Add Google Public DNS IPv6 and Cloudflare DNS IP addresses to `resolver` (h5bp#229)
  Fix misc typos in comments (h5bp#228)
  Update README.md
  Fix typo in example conf (h5bp#226)
  Improve default Content-Security-Policy value (h5bp#224)
  ...
Copy link

@nicepc nicepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey my name sis Nick Urrabazo. I want to know who is the original requester on this thread of 232 . I am 007 I am the owner of the property permits and licensing. Not the least valuable. What it looks like is you just help these people steal 100 million dollars from me!!! Get back to work and fix this issue. If you ever have any more questions or request for 232 223 .You need to get in contact with me . Robert Nicholas Urrabazo

@petecooper
Copy link
Contributor Author

@nurrabazo –

I want to know who is the original requester on this thread of 232

That's me.

What it looks like is you just help these people steal 100 million dollars from me!!!

No, I updated some documentation.

You're in the wrong place, take it elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants