Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc typos in comments #228

Merged
merged 2 commits into from
May 14, 2019
Merged

Fix misc typos in comments #228

merged 2 commits into from
May 14, 2019

Conversation

petecooper
Copy link
Contributor

IPv6 addresses are for Google Public DNS — I could not find any IPv6 addresses for Dyn.

IPv6 addresses are for Google Public DNS — I could not find any IPv6 addresses for Dyn.
@LeoColomb
Copy link
Member

Thanks @petecooper. Can you separate typo fixes from IP changes? Another PR for the IP change would help us reviewing. 🙂

Revert IPv6 addresses, will split.

#228 (comment)
@petecooper petecooper changed the title misc typos, add 2x IPv6 addresses to resolver misc typos May 14, 2019
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, really nice @petecooper!
A little horrified to see all these mistakes... 😱😉

LGTM 👍

@LeoColomb LeoColomb changed the title misc typos Fix misc typos in comments May 14, 2019
@LeoColomb LeoColomb merged commit e300321 into h5bp:master May 14, 2019
@petecooper
Copy link
Contributor Author

A little horrified to see all these mistakes...

Your English language skill is much stronger than my French language skill!

memuller added a commit to memuller/nginx-config that referenced this pull request Aug 26, 2019
* 'master' of github.com:h5bp/server-configs-nginx: (92 commits)
  Additional compression method added for gzip (h5bp#236)
  Bump server-config-test to 1.2.1
  Switch tertiary DNS used for OCSP checking to OpenDNS (h5bp#235)
  Revert "Drop Cache-Control: no-transform usage"
  Release v3.1.0
  Fix CHANGELOG formatting
  Use generic `$host` instead of host name
  Pre-compressed content usage config files
  Fix rebase artifacts
  Documentation formatting and reviewing (h5bp#232)
  Fix 304 responses Cache-control override
  Fix dropped Cache-Control: no-transform usage for SVGZ Compression
  Bump server-configs-test to v1.1.0
  Improve wording and file headers
  Drop Cache-Control: no-transform usage
  Add Google Public DNS IPv6 and Cloudflare DNS IP addresses to `resolver` (h5bp#229)
  Fix misc typos in comments (h5bp#228)
  Update README.md
  Fix typo in example conf (h5bp#226)
  Improve default Content-Security-Policy value (h5bp#224)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants