Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#322): move ghminer files to sr-data resources #327

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat(#322): move ghminer files to sr-data resources #327

merged 1 commit into from
Feb 6, 2025

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Feb 6, 2025

In this PR I moved ghminer files from root to sr-data resources.

closes #322


PR-Codex overview

This PR focuses on enhancing the ghminer command by adding support for GraphQL and JSON schema files, which improves data querying capabilities.

Detailed summary

  • Added --graphql option to specify the GraphQL file path (sr-data/resources/ghminer.graphql).
  • Added --schema option to specify the JSON schema file path (sr-data/resources/ghminer.json).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (64f7804) to head (4a0cc82).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files          21       21           
  Lines         622      622           
=======================================
  Hits          516      516           
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 6, 2025

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 7f8a918 into master Feb 6, 2025
20 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 6, 2025

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 12min).

@h1alexbel h1alexbel deleted the 322 branch February 6, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ghminer.json and ghminer.graphql should be declared as resources
2 participants