Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghminer.json and ghminer.graphql should be declared as resources #322

Closed
h1alexbel opened this issue Feb 4, 2025 · 3 comments · Fixed by #327
Closed

ghminer.json and ghminer.graphql should be declared as resources #322

h1alexbel opened this issue Feb 4, 2025 · 3 comments · Fixed by #327
Assignees
@h1alexbel
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@h1alexbel
Copy link
Owner

Currently, we have them in the root directory, while it's not the best place for them. Let's move them to resources of sr-data package
@h1alexbel h1alexbel added bug Something isn't working good first issue Good for newcomers labels Feb 4, 2025
@h1alexbel h1alexbel self-assigned this Feb 6, 2025
h1alexbel added a commit that referenced this issue Feb 6, 2025
@h1alexbel
feat(#322): move ghminer files
4a0cc82
@h1alexbel h1alexbel mentioned this issue Feb 6, 2025
Merged
@h1alexbel
Copy link
Owner Author

@rultor release, tag is 0.0.38

@rultor
Copy link
Collaborator

rultor commented Feb 6, 2025

@rultor release, tag is 0.0.38

@h1alexbel OK, I will release it now. Please check the progress here.

@rultor
Copy link
Collaborator

rultor commented Feb 6, 2025

@rultor release, tag is 0.0.38

@h1alexbel Done! FYI, the full log is here (took me 19min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h1alexbel h1alexbel

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#322): move ghminer files to sr-data resources h1alexbel/sr-detection
2 participants
@rultor @h1alexbel