V239 changes #5031
V239 changes #5031
Conversation
* Report significance fit info in sngls_findtrigs * Report significance calculation info in statmap jobs * Fix typo, fix test * TD comments, some tidying up * neaten comments * comment fix --------- Co-authored-by: Thomas Dent <thomas.dent@usc.es>
titodalcanton
added
v23_release_branch
|
I think we also need #4901 for the tests to pass. |
|
Merged #4901 now, though I doubt this will be the only one. I'll also try and figure out how to built a singularity image that will be able to transfer OSDF files with the current pegasus release. |
* try macos latest version * move to update macos on build as well
* tox: fix tox integration with conda use setup-miniconda github action and specify more packages in conda_deps for each testenv * tox: install ligo-segments and python-ligo-lw with conda these packages don't install cleanly with pypi, but the conda packages have patches * test: use numpy.longdouble instead of float128 float128 isn't available on macOS ARM64 * tox: clean up duplicate package lists * ci: unpin tox * tox: further simplify duplicate configuration
Dockerfile
Outdated
| @@ -11,7 +11,7 @@ RUN dnf -y install https://ecsft.cern.ch/dist/cvmfs/cvmfs-release/cvmfs-release- | |||
| dnf -y groupinstall "Development Tools" \ | |||
| "Scientific Support" && \ | |||
| rpm -e --nodeps git perl-Git && dnf -y install @python39 rsync zlib-devel libpng-devel libjpeg-devel sqlite-devel openssl-devel fftw-libs-single fftw-devel fftw fftw-libs-long fftw-libs fftw-libs-double gsl gsl-devel hdf5 hdf5-devel python39-devel swig which osg-ca-certs && python3.9 -m pip install --upgrade pip setuptools wheel cython && python3.9 -m pip install mkl ipython jupyter jupyterhub jupyterlab lalsuite && \ | |||
| dnf -y install https://repo.opensciencegrid.org/osg/3.5/el8/testing/x86_64/osg-wn-client-3.5-5.osg35.el8.noarch.rpm && dnf clean all | |||
| dnf -y install https://repo.opensciencegrid.org/osg/3.5/el8/testing/x86_64/osg-wn-client-3.5-5.osg35.el8.noarch.rpm && dnf -y install pelican-osdf-compat-7.10.5-1.x86_64 && dnf -y install pelican-7.10.5-1.x86_64 && dnf clean all | |||
There was a problem hiding this comment.
@rahuldhurkunde Here is what is needed for using the old stashcp (I think)
There was a problem hiding this comment.
(got the version number wrong, should have been 7.10.11, not 7.10.5)
There was a problem hiding this comment.
@spxiwh I'm not able to build an image with this :(
274.8 Error: Unable to find a match: pelican-osdf-compat-7.10.5-1.x86_64
| @@ -217,7 +217,7 @@ def run(self): | |||
| 'vetoes.chisq'] | |||
| ext = [] | |||
| cython_compile_args = ['-O3', '-w', '-ffast-math', | |||
| '-ffinite-math-only'] | |||
| '-fno-finite-math-only'] | |||
There was a problem hiding this comment.
Okay, the CI is now passing (yay), but I am concerned about having had to make this change. I don't understand why it hasn't also affected the main branch. The underlying issue is a change in a core library (I think libm) to remove the explicit finite math functions (I'm not clear if this is now deprecated and this flag does nothing, or if they are implemented differently). However, it seems that the code is built against one version (of libm), but then links against a different version when running, which then causes a missing flag failure.
I don't think this will change much. It may slightly impact performance of the cython code, but I suspect it would be marginal if noticeable at all.
Not yet ready to be merged, but I'll log the changes for the v239 release here. I expect some compatibility issues will require some other patches to be added, but will let the test suite tell me.
I think GWOSC is down right now, so we may have to wait for that to be fixed.