-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try macos latest version #4922
try macos latest version #4922
Conversation
@titodalcanton This patch solves the immediate problem of macos 12 going away by bumping up our versions. I think for the builds we should stick with a fixed version so this advances us to 14, but for the tests I think it makes sense to work with the latest. The old PR tried to do some additional things to merge the macos test and linux ones. That turned out to be more complicated than I'd like. I might revisit it at some point, but this separates out the needed part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I agree with sticking to an explicit version for builds.
* try macos latest version * move to update macos on build as well
* Fix bug in fetching injection group param * try macos latest version (gwastro#4922) (gwastro#4926) * try macos latest version * move to update macos on build as well Co-authored-by: Alex Nitz <alex.nitz@gmail.com> --------- Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
* try macos latest version * move to update macos on build as well
* Fix bug in fetching injection group param * try macos latest version (gwastro#4922) (gwastro#4926) * try macos latest version * move to update macos on build as well Co-authored-by: Alex Nitz <alex.nitz@gmail.com> --------- Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
* try macos latest version * move to update macos on build as well
* try macos latest version (#4922) * try macos latest version * move to update macos on build as well * Increment version to 2.7.2 --------- Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
* try macos latest version * move to update macos on build as well
No description provided.