Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try macos latest version #4922

Merged
merged 2 commits into from
Nov 4, 2024
Merged

try macos latest version #4922

merged 2 commits into from
Nov 4, 2024

Conversation

ahnitz
Copy link
Member

@ahnitz ahnitz commented Nov 4, 2024

No description provided.

@ahnitz ahnitz mentioned this pull request Nov 4, 2024
1 task
@ahnitz
Copy link
Member Author

ahnitz commented Nov 4, 2024

@titodalcanton This patch solves the immediate problem of macos 12 going away by bumping up our versions. I think for the builds we should stick with a fixed version so this advances us to 14, but for the tests I think it makes sense to work with the latest.

The old PR tried to do some additional things to merge the macos test and linux ones. That turned out to be more complicated than I'd like. I might revisit it at some point, but this separates out the needed part.

Copy link
Contributor

@titodalcanton titodalcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I agree with sticking to an explicit version for builds.

@ahnitz ahnitz merged commit f160641 into gwastro:master Nov 4, 2024
29 checks passed
tdent added a commit that referenced this pull request Nov 4, 2024
* try macos latest version

* move to update macos on build as well

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
tdent added a commit that referenced this pull request Nov 4, 2024
* Fix bug in fetching injection group param

* try macos latest version (#4922) (#4926)

* try macos latest version

* move to update macos on build as well

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>

---------

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
pannarale pushed a commit to pannarale/pycbc that referenced this pull request Nov 7, 2024
* try macos latest version

* move to update macos on build as well
pannarale pushed a commit to pannarale/pycbc that referenced this pull request Nov 7, 2024
* Fix bug in fetching injection group param

* try macos latest version (gwastro#4922) (gwastro#4926)

* try macos latest version

* move to update macos on build as well

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>

---------

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
prayush pushed a commit to prayush/pycbc that referenced this pull request Nov 21, 2024
* try macos latest version

* move to update macos on build as well
prayush pushed a commit to prayush/pycbc that referenced this pull request Nov 21, 2024
* Fix bug in fetching injection group param

* try macos latest version (gwastro#4922) (gwastro#4926)

* try macos latest version

* move to update macos on build as well

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>

---------

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
maxtrevor pushed a commit to maxtrevor/pycbc that referenced this pull request Dec 6, 2024
* try macos latest version

* move to update macos on build as well
maxtrevor added a commit that referenced this pull request Dec 6, 2024
* try macos latest version (#4922)

* try macos latest version

* move to update macos on build as well

* Increment version to 2.7.2

---------

Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
spxiwh pushed a commit to spxiwh/pycbc that referenced this pull request Feb 6, 2025
* try macos latest version

* move to update macos on build as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants