Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure sampling parameters keep the same order #3377

Merged
merged 1 commit into from
Jul 13, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pycbc/inference/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ def __init__(self, variable_params, sampling_params,
if arg not in replace_parameters]
# add the sampling parameters
self.sampling_params += sampling_params
# sort to make sure we have a consistent order
self.sampling_params.sort()
self.sampling_transforms = sampling_transforms

def logjacobian(self, **params):
Expand Down Expand Up @@ -272,7 +274,7 @@ def read_sampling_params_from_config(cp, section_group=None,
map_args = cp.get(section, args)
sampling_params.update(set(map(str.strip, map_args.split(','))))
replaced_params.update(set(map(str.strip, args.split(','))))
return list(sampling_params), list(replaced_params)
return sorted(sampling_params), sorted(replaced_params)


#
Expand Down