Make sure sampling parameters keep the same order #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnitz
approved these changes
Jul 13, 2020
lenona
pushed a commit
to lenona/pycbc
that referenced
this pull request
Sep 14, 2020
OliverEdy
pushed a commit
to OliverEdy/pycbc
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when using sampling parameters with MPI. When the parameters are loaded from the config file, they are initialized as a set, then converted to a list. However,
setdoesn't preserve order. This means that different slave nodes when running under MPI will think the sampler is giving it parameters in a different order than it is. This fixes this by sorting the sampling parameters (both when they are loaded, and when they are saved to the model's sampling_params attribute... just to be sure). This only would of effected emcee and emcee_pt, and only when running on MPI. Apparently this wasn't an issue in python 2.7, but is in 3.XX.