Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Add /api/register-agent endpoint #3084

Merged
merged 7 commits into from
Mar 10, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 9, 2023

What does this PR do?

Fixes part of #3076.

Adds mock endpoint for getting token (requires OTP).

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore
Copy link
Collaborator

also for this: #3083 (comment)

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (c254126) 67.58% compared to head (69eff25) 67.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3084      +/-   ##
===========================================
+ Coverage    67.58%   67.62%   +0.04%     
===========================================
  Files          444      445       +1     
  Lines        12730    12751      +21     
===========================================
+ Hits          8603     8623      +20     
- Misses        4127     4128       +1     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shreyamalviya shreyamalviya force-pushed the 3076-add-mock-agent-registration-resource branch from 2e897c0 to 30878cf Compare March 10, 2023 12:20
@mssalvatore
Copy link
Collaborator

After much discussion, we settled on GET /api/agent-otp and POST /api/agent-otp-login.

@ilija-lazoroski ilija-lazoroski force-pushed the 3076-add-mock-agent-registration-resource branch from 6855de9 to 5854c50 Compare March 10, 2023 14:34
@ilija-lazoroski ilija-lazoroski force-pushed the 3076-add-mock-agent-registration-resource branch from 5854c50 to 69eff25 Compare March 10, 2023 15:13
@mssalvatore mssalvatore merged commit e23317c into develop Mar 10, 2023
@mssalvatore mssalvatore deleted the 3076-add-mock-agent-registration-resource branch March 10, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants