Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Add /api/request-otp endpoint #3083

Merged
merged 6 commits into from
Mar 10, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 9, 2023

What does this PR do?

Fixes part of #3076.

Adds mock endpoint for requesting OTP

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore
Copy link
Collaborator

Could we base this off of 2157-consolidate-authentication-service-logic (which will probably get merged tomorrow? This will lead to less rework/conflict resolution than the other way around.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (34d06df) 67.56% compared to head (3b184e5) 67.58%.

❗ Current head 3b184e5 differs from pull request most recent head a25ac6c. Consider uploading reports for the commit a25ac6c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3083      +/-   ##
===========================================
+ Coverage    67.56%   67.58%   +0.01%     
===========================================
  Files          443      444       +1     
  Lines        12720    12730      +10     
===========================================
+ Hits          8594     8603       +9     
- Misses        4126     4127       +1     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shreyamalviya shreyamalviya force-pushed the 3076-add-mock-otp-request-resource branch 3 times, most recently from f150f5d to a975ae4 Compare March 10, 2023 11:59
@mssalvatore
Copy link
Collaborator

After much discussion, we settled on GET /api/agent-otp and POST /api/agent-otp-login.

@ilija-lazoroski ilija-lazoroski force-pushed the 3076-add-mock-otp-request-resource branch from 3b184e5 to a25ac6c Compare March 10, 2023 14:35
@mssalvatore mssalvatore merged commit c254126 into develop Mar 10, 2023
@mssalvatore mssalvatore deleted the 3076-add-mock-otp-request-resource branch March 10, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants