Use Vite #279
Merged
Use Vite #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/use-vite
branch
from
7048539 to
63f3370
Compare
phillipbarron
approved these changes
Mar 21, 2023
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Use Vite, not webpack, for our client side builds.
Why?
swcPreviously, Scala was recompiling as a result of asset changes, so this is a significant improvement to the feedback loop when developing server side.
How to test
Run locally by running
./scripts/start-manager. The app should run locally as expected, backgrounding the build server. Try changing something in the components. The app should update in realtime.Test the build process – which is quite different from the local dev process! – by deploying to CODE. The app should run as expected.
How can we measure success?
A better feedback loop for devs, and a smaller bundle size in production.