Add basic page layout with EUI #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
reviewed
Mar 20, 2023
phillipbarron
approved these changes
Mar 21, 2023
|
That's right, elastic/eui#6182 is tracking that issue. The list of issues is small, so hopefully it's not too far off! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a basic page layout with EUI. Behold:
Dev notes
Behold, but less triumphantly (this is a production build running in CODE):
... that'll be the next PR 😅. Other tools that use EUI in production come in at about 500kb, so this is likely a problem with our build. Build times are also appalling – I suspect a move to Vite may kill both birds with one stone.
Other notes: I've added a basic CSS reset, taking a few things from here. There's also a CSS override to ensure that our headings are Guardian-specific. I thought this was more elegant than custom heading components for each heading level, but we could move this to heading components if others felt strongly.
How to test
Run locally, or in CODE, remembering to run
npm iwithin rule-manager-client to refresh dependencies –@guardian/sourceis out,@elastic/euiis in.