This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #814 |
SiAdcock
reviewed
Aug 6, 2021
SiAdcock
reviewed
Aug 6, 2021
SiAdcock
reviewed
Aug 6, 2021
Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
SiAdcock
reviewed
Aug 6, 2021
SiAdcock
reviewed
Aug 6, 2021
SiAdcock
reviewed
Aug 6, 2021
SiAdcock
reviewed
Aug 6, 2021
Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
@SiAdcock where did we end up on the layout / not layout discussion? Are you okay keeping this divider as it's own thing? |
@oliverlloyd what do you think about adding this to the Development Kitchen (#963)? To answer your previous question, for now I think Divider makes sense as its own thing |
👍 I'll cook something up |
👨🍳👌 |
SiAdcock
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely stuff, thanks @oliverlloyd . Divide. Conquer. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Button
Changes to the button component
Choice card
Changes to the choice card component
foundations
Affects @guardian/source-foundations
kitchen
Affects @guardian/source-react-components-development-kitchen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divider
Inserts a line on the page acting as a section break dividing content
Install
Use
Divider Props
size
'partial' | 'full'
full
means the divider will span the full width of the contentpartual
left aligns the divider and limits its lengthspaceAbove
'tight' | 'loose'
How much space is given above the divider
displayText
string
This text is centered inside the dividing line