This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
Optimise best logo SVG #1024
Merged
Optimise best logo SVG #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the power of SVG with source’s palette
probot-autolabeler
bot
added
the
kitchen
mxdvl
requested review from
SiAdcock and
a team
and removed request for
a team
SiAdcock
reviewed
Oct 6, 2021
packages/@guardian/source-react-components-development-kitchen/components/logo/Logo.tsx
Outdated
Show resolved
Hide resolved
sndrs
reviewed
Oct 7, 2021
packages/@guardian/source-react-components-development-kitchen/components/logo/Logo.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Sanders <alex@sndrs.dev>
- 2-decimal precision - groupings based on colour - attributes indicating the content
This should improve accessibility for screen readers Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
|
The Tested with a screen reader link does not seem to be working. Apart from that, I think this is good to go? It’s a small improvement, but acts as a reminded that SVG is code representing graphics! We could also use fonts directly, if we know they’re available, but I appreciate that this could go against brand safety. |
Good spot! I've fixed them in #1076 |
sndrs
approved these changes
Oct 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Use the declarative nature of SVG with the power of source’s uniform palette implementation. Lower the precision of the SVG source to 1 decimal place using SVGOMG, because it’s visually identical at 200x zoom.
Adds a
data-contentattribute which connects the SVG paths with what they contain.What does this change?
The source code for the Guardian Logo.
Screenshots
Checklist
Accessibility
Cross browser and device testing
Responsiveness
Documentation
Known issues