This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Tweak Caption Styles #287
Merged
Tweak Caption Styles #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjust line height to 'regular' (1.35) - Reduce font size to 12px - Change font colour in dark mode
|
@JamieB-gu A top margin of 6px just looks exactly right for the captions. If we can't have, it use 8px, as you did. Let's discuss with Akemi. |
faresite
approved these changes
Jun 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Applying some tweaks to the image caption styles requested by @benwuersching.
Note: Ben, one thing you requested was a
6pxspacing between the caption text and the bottom of the image. However the design system only allows for spacings that are multiples of4px, so I've kept it at8pxfor now. If you think this is problematic maybe we should have a chat with Akemi about the rules for spacing?Note 2: The text colour you requested for dark mode was
#999. Interestingly the only instance of that colour for text in the design system isbrandAltText.supporting, as seen here. I've used that, but it's a weird name for a default theme dark mode colour. We're probably going to have to think about integrating an official dark mode palette into the design system at some point 🤔.Changes