Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

LIVE-2648: Caption style fix #1359

Closed
wants to merge 3 commits into from
Closed

Conversation

faresite
Copy link
Contributor

Why are you doing this?

@JamieB-gu made this PR implementing the caption design fixes guardian/image-rendering#287

This PR simply tests the fix by bumping image-rendering to that PR's commit version.

Screenshots

Before After

@JamieB-gu
Copy link
Contributor

JamieB-gu commented Jun 28, 2021

@faresite release here.

@faresite
Copy link
Contributor Author

@JamieB-gu I bumped it to v7.0.0 but I can't get it to build, I'm getting some dependency resolve errors, they're a bit odd as it mentions guardian/image-rendering@6.0.0 but there's no reference to 6.0.0 the package lock . I'm trying to find it manually in the dependency tree but haven't found it yet. The full error is:

npm ERR! npm ERR! While resolving: @guardian/image-rendering@6.0.0
npm ERR! npm ERR! Found: typescript@4.3.4
npm ERR! npm ERR! node_modules/typescript
npm ERR! npm ERR!   typescript@"^4.3.4" from the root project
npm ERR! npm ERR!
npm ERR! npm ERR! Could not resolve dependency:
npm ERR! npm ERR! peer typescript@"^3.8.0" from @guardian/types@4.0.0
npm ERR! npm ERR! node_modules/@guardian/types
npm ERR! npm ERR!   @guardian/types@"github:guardian/types#semver:^4.0.0" from the root project

@faresite faresite added Do not merge ⚠️ Request is not ready for releasing blocked labels Jun 29, 2021
@faresite
Copy link
Contributor Author

faresite commented Jun 29, 2021

There's a concern that the captions are smaller than the templates, and this PR would be make it even smaller. Will need to clarify this with design and UX, however not a blocker at the moment as long as we don't merge the even smaller caption text. hence blocked.

@prisalcalde @benwuersching

@joecowton1
Copy link
Contributor

Closing.

@joecowton1 joecowton1 closed this Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked Do not merge ⚠️ Request is not ready for releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants