Fix release so that it does not attempt to use Scala 2.12 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #318 dropped support for Scala 2.12, release 8.0.1 correctly no longer published Scala 2.12 artifacts, but unfortunately the 'root' project (which does not have any code!) was still defaulting to using Scala 2.12, because that is the default sbt uses if no `scalaVersion` is set. The next time we tried to do a release (#319 (comment)) the automated-compatibility checking failed, because it saw that one project was using Scala 2.12, and so it attempted to download all the non-existent Scala 2.12 artifacts for release 8.0.1 - and failed. To fix this, we can simply ensure that all modules in this sbt build default to Scala 2.13, not 2.12 - ie particularly, the 'root' module!
|
@rtyley has published a preview version of this PR with release workflow run #30, based on commit 6574ed3: 8.0.2-PREVIEW.fix-release-process-so-that-it-does-not-attempt-to-use-scala-212.2024-08-02T1015.6574ed36 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the fix-release-process-so-that-it-does-not-attempt-to-use-scala-2.12 branch, or use the GitHub CLI command: gh workflow run release.yml --ref fix-release-process-so-that-it-does-not-attempt-to-use-scala-2.12 Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
rtyley
deleted the
fix-release-process-so-that-it-does-not-attempt-to-use-scala-2.12
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #318 dropped support for Scala 2.12, release 8.0.1 correctly no longer published Scala 2.12 artifacts, but unfortunately the 'root' project (which does not have any code!) was still defaulting to using Scala 2.12, because that is the default sbt uses if no
scalaVersionis set.The next time we tried to do a release (#319 (comment)) the automated-compatibility checking failed, because it saw that one project was using Scala 2.12, and so it attempted to download all the non-existent Scala 2.12 artifacts for release 8.0.11 - and failed.
To fix this, we can simply ensure that all modules in this sbt build default to Scala 2.13, not 2.12 - ie particularly, the 'root' module!
Testing
We ran a preview release on this PR, and the automated-compatibility checking succeeded 👍 :
Footnotes
This behaviour seems like a bug in
sbt-version-policy?!sbt-version-policyis already aware of thepublish / skip := trueflag, so should know thatrootdoes not have any artifacts... ↩