Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fairground] Add BoostLevel attribute in card meta data #319

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

waisingyiu
Copy link
Contributor

@waisingyiu waisingyiu commented Jul 31, 2024

What does this change?

We (the fairground team) is building the new dynamic containers as part of the homepage redesign project.

A pull request guardian/facia-tool#1611 has been raised to support new dynamic containers in the fronts tool. A new property boostLevel is added to the meta data of cards.

This pull request extends the facia Scala client library to expose the boostLevel as a new property of ContentProperties to the platform.

How to test

Test cases have been added to validate the new property.

Deployment

  • Updated facia-tool to use latest version
  • Updated frontend to use latest version
  • Updated MAPI to use latest version
  • Updated Ophan to use latest version
  • Updated story-packages to use latest version
  • Updated apple-news to use latest version
  • Checked for other downstream dependencies (perhaps via snyk or github search)

@waisingyiu waisingyiu force-pushed the fairground/add-new-boost-level branch 2 times, most recently from 63a6135 to 4ef0110 Compare August 1, 2024 12:19
@gu-scala-library-release
Copy link
Contributor

@waisingyiu has published a preview version of this PR with release workflow run #28, based on commit a545ec4:

8.0.2-PREVIEW.fairgroundadd-new-boost-level.2024-08-01T1655.a545ec42

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the fairground/add-new-boost-level branch, or use the GitHub CLI command:

gh workflow run release.yml --ref fairground/add-new-boost-level

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

rtyley added a commit that referenced this pull request Aug 2, 2024
After #318 dropped
support for Scala 2.12, release 8.0.1 correctly no longer published Scala 2.12
artifacts, but unfortunately the 'root' project (which does not have any
code!) was still defaulting to using Scala 2.12, because that is the
default sbt uses if no `scalaVersion` is set.

The next time we tried to do a release (#319 (comment))
the automated-compatibility checking failed, because it saw that one project
was using Scala 2.12, and so it attempted to download all the non-existent
Scala 2.12 artifacts for release 8.0.1 - and failed.

To fix this, we can simply ensure that all modules in this sbt build default
to Scala 2.13, not 2.12 - ie particularly, the 'root' module!
@waisingyiu waisingyiu force-pushed the fairground/add-new-boost-level branch from a545ec4 to e0f7dfa Compare August 2, 2024 10:29
@gu-scala-library-release
Copy link
Contributor

@waisingyiu has published a preview version of this PR with release workflow run #31, based on commit e0f7dfa:

9.0.0-PREVIEW.fairgroundadd-new-boost-level.2024-08-02T1030.e0f7dfa6

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the fairground/add-new-boost-level branch, or use the GitHub CLI command:

gh workflow run release.yml --ref fairground/add-new-boost-level

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@waisingyiu waisingyiu changed the title Add support for BoostLevel attribute [fairground] Add support for BoostLevel attribute Aug 2, 2024
@waisingyiu waisingyiu changed the title [fairground] Add support for BoostLevel attribute [fairground] Add BoostLevel attribute in card meta data Aug 2, 2024
@waisingyiu waisingyiu requested review from cemms1, Georges-GNM and a team August 2, 2024 10:47
@waisingyiu waisingyiu marked this pull request as ready for review August 2, 2024 10:48
@Georges-GNM Georges-GNM merged commit 1d25df7 into main Aug 8, 2024
10 checks passed
@Georges-GNM Georges-GNM deleted the fairground/add-new-boost-level branch August 8, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants