Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sbt config no longer needed with automated-maven-release #24

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Remove sbt config no longer needed with automated-maven-release #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
addSbtPlugin("com.github.sbt" % "sbt-release" % "1.1.0")

addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.2.1")
Copy link
Member Author

@rtyley rtyley Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need sbt-pgp at all anymore, because we now just use bare gpg to sign the artifacts:

https://github.com/guardian/github-actions-automated-maven-release/blob/107ca3890bd46986bd43f71993dba785dd802583/.github/workflows/reusable-automated-maven-release.yml#L198

We can just use gpg because the file structure is now simpler - just sign everything in a folder - and I believe we now get benefit from using bare gpg, because of the GitHub Job isolation that automated-maven-release is doing:

image


addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.9.21")
4 changes: 0 additions & 4 deletions sonatype.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
sonatypeProfileName := "com.gu"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to set sonatypeProfileName because it's set for us in reusable-automated-maven-release.yml :

https://github.com/guardian/github-actions-automated-maven-release/blob/107ca3890bd46986bd43f71993dba785dd802583/.github/workflows/reusable-automated-maven-release.yml#L250

The sonatypeProfileName is going to be the same for all the repos in our organisation: com.gu - note we can still set a distinct group id for our artifacts using the organization setting:

etag-caching/sonatype.sbt

Line 5 in acac7af

ThisBuild / organization := "com.gu.etag-caching"


ThisBuild / publishTo := Some(Resolver.file("roberto-test", file("/tmp/funky"))) // sonatypePublishToBundle.value

ThisBuild / organization := "com.gu.etag-caching"

ThisBuild / scmInfo := Some(ScmInfo(
Expand Down