Remove sbt config no longer needed with automated-maven-release #24
Conversation
|
Mock info: This PR Breaks Binary Compatibility when compared against most recent release 3.0.0. Details... |
| @@ -1,5 +1,3 @@ | |||
| addSbtPlugin("com.github.sbt" % "sbt-release" % "1.1.0") | |||
|
|
|||
| addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.2.1") | |||
There was a problem hiding this comment.
We don't need sbt-pgp at all anymore, because we now just use bare gpg to sign the artifacts:
We can just use gpg because the file structure is now simpler - just sign everything in a folder - and I believe we now get benefit from using bare gpg, because of the GitHub Job isolation that automated-maven-release is doing:
| @@ -1,7 +1,3 @@ | |||
| sonatypeProfileName := "com.gu" | |||
There was a problem hiding this comment.
We don't need to set sonatypeProfileName because it's set for us in reusable-automated-maven-release.yml :
The sonatypeProfileName is going to be the same for all the repos in our organisation: com.gu - note we can still set a distinct group id for our artifacts using the organization setting:
Line 5 in acac7af
rtyley
deleted the
remove-some-sbt-config-no-longer-needed-with-automated-maven-release
branch
https://github.com/guardian/github-actions-automated-maven-release