echo GuSSMParameter values by default #143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The value of GuSSMParameter will be the path into parameter store. This isn't private, so setting noEcho should not be the default.
I observed this whilst applying https://github.com/guardian/deploy-tools-platform/pull/323. The value of
LoggingStreamName
is defaulted and withnoEcho
set totrue
, it caused for an interesting CFN update as had to triple check the redacted value.It is still possible to set
noEcho
and have added a test to demonstrate this.Does this change require changes to existing projects or CDK CLI?
No.
How to test
Tests have been added.
How can we measure success?
Better default behaviour of the
GuSSMParameter
.Have we considered potential risks?
n/a