Allow all parameters to be from SSM #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-lynch
added
the
needs-new-release
akash1810
approved these changes
Jan 14, 2021
| it("passes through other values without modification", () => { | ||
| const stack = simpleGuStackForTesting(); | ||
|
|
||
| new GuParameter(stack, "Parameter", { type: "Boolean", fromSSM: true, description: "This is a test" }); |
There was a problem hiding this comment.
We might want to make type an enum or validate it at some point, for a later PR though.
akash1810
reviewed
Jan 14, 2021
Co-authored-by: Akash Askoolum <akash1810@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates the
GuParameterto take a newfromSSMprop. If this prop is set to true then thetypevalue will be wrapped withAWS::SSM::Parameter::Value. This means that all parameters extending theGuParametercan now be denoted asfromSSM. Due to the, theGuSSMParameterhas been removed and the one case where it was used has been updated.Does this change require changes to existing projects or CDK CLI?
Yes. Anywhere that is currently using the
GuSSMParameterwill need to be updated to use another construct with thefromSSMvalue set to true.How to test
New unit tests have been added to cover the exact functionality. The
GuLogShippingPolicywas usingGuSSMParameterand has been refactored so you can also see that it still produces the same cloudformation.How can we measure success?
GuParameter constructs present a more consistent interface with regard to getting values from SSM.