internal: update golint to use new url #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jadekler |
jeanbza
force-pushed
the
na_update_golint_url
branch
from
5f3fb2f
to
5061be6
Compare
|
PTAL (used |
jeanbza
force-pushed
the
na_update_golint_url
branch
from
5061be6
to
0b13e05
Compare
jeanbza
force-pushed
the
na_update_golint_url
branch
from
0b13e05
to
abde508
Compare
gopherbot
pushed a commit
to golang/build
that referenced
this pull request
Mar 14, 2019
Version v1.16.0 of the grpc module is known to be bad (because it doesn't include the fix from grpc/grpc-go#2393), so we don't want to require it, even indirectly. Commands run: go mod edit -droprequire=google.golang.org/grpc go mod tidy go test ./... Updates golang/go#30833 Change-Id: I549dd5276ae19aa89c18cf2e9c981e81b8ffdd11 Reviewed-on: https://go-review.googlesource.com/c/build/+/167597 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the repo moved)
(I have zero experience with go modules and do not have a good idea of whether more changes are needed to go.mod)