Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update grpc from v1.16.0 to v1.17.0 #880

Merged
merged 2 commits into from
Feb 28, 2019
Merged

go.mod: update grpc from v1.16.0 to v1.17.0 #880

merged 2 commits into from
Feb 28, 2019

Conversation

klim0v
Copy link
Contributor

@klim0v klim0v commented Feb 28, 2019

Update the grpc dependency to v1.17.0, which includes the fix
to remove the invalid github.com/golang/lint module requirement
in grpc/grpc-go#2393.

This change was generated by running the following commands
using Go 1.11:

go get google.golang.org/grpc@v1.17.0
go mod tidy

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files          39       39           
  Lines        3913     3913           
=======================================
  Hits         2075     2075           
  Misses       1642     1642           
  Partials      196      196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206758a...35ee0a8. Read the comment docs.

@klim0v
Copy link
Contributor Author

klim0v commented Feb 28, 2019

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@klim0v
Copy link
Contributor Author

klim0v commented Feb 28, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johanbrandhorst
Copy link
Collaborator

The gRPC project recently released 1.19.0 - why not go all the way? Could you try updating to 1.19.0 and see if we get any errors?

@klim0v
Copy link
Contributor Author

klim0v commented Feb 28, 2019

Could you try updating to 1.19.0 and see if we get any errors?

Yes, I'll do it

@klim0v
Copy link
Contributor Author

klim0v commented Feb 28, 2019

It's work

@johanbrandhorst
Copy link
Collaborator

Nice, thanks! I'll just need to confirm with @achew22 that this is still correct in Bazel land before merging.

@achew22
Copy link
Collaborator

achew22 commented Feb 28, 2019

grpc is a dependency that gets managed by rules_go so this is good to go. Thanks so much for the PR!

@achew22 achew22 merged commit fff1507 into grpc-ecosystem:master Feb 28, 2019
@klim0v klim0v deleted the update-grpc branch March 1, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants