fix query params not populate if method is post

[mingqing]

for http method post and content-type is application/x-www-form-urlencoded, the query parameters will be in Request.Form or Request.PostForm.

[johanbrandhorst]

Hi @mingqing, thanks for your pull request. The failing CI test is because you need to regenerate the example files. Please see CONTRIBUTING.md in the root of the repo for a docker one liner.

Also, could you add a test that fails before this change and works after it?

Thanks!

[codecov-io]

Codecov Report

Merging #939 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
- Coverage   53.84%   53.79%   -0.06%     
==========================================
  Files          40       40              
  Lines        3965     3969       +4     
==========================================
  Hits         2135     2135              
- Misses       1634     1638       +4     
  Partials      196      196

Impacted Files	Coverage Δ
protoc-gen-grpc-gateway/gengateway/template.go	65.51% <ø> (ø)	⬆️
examples/server/a_bit_of_everything.go	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f6fca...f031a59. Read the comment docs.

[mingqing]

@johanbrandhorst I regenerated the file and added it, while passing the CI test.

[johanbrandhorst]

This still doesn't contain the test I requested. Please see the integration test folder for an example of a test. I would like you to add a new test case that exercises this new branch in the generated code please.

[johanbrandhorst]

The latest update confuses me - I encourage you to add a test case before anything else.

[johanbrandhorst]

Thanks for the explanation, however, we still need a new test case that was failing before this change and is now passing. Do you need some help to write the test?

[mingqing]

Thanks for the explanation, however, we still need a new test case that was failing before this change and is now passing. Do you need some help to write the test?

Is the test case added in examples/integration/integration_test.go? I will go add.

[johanbrandhorst]

Thanks for the explanation, however, we still need a new test case that was failing before this change and is now passing. Do you need some help to write the test?

Is the test case added in examples/integration/integration_test.go? I will go add.

Yes, that would be great, thanks.

[johanbrandhorst]

Thanks for adding the tests, I took the liberty of trying to run the tests without the changes applied and was pleased to see that the PostForm test failing, which makes it easier to understand the scope of the change.

[johanbrandhorst]

Thanks for the latest slew of changes, just a new small pointers then we can merge this!

[johanbrandhorst]

This looks great now, thanks a lot!

[johanbrandhorst]

Thanks for your contribution!