Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix query params for invoked in-process local request #1212

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

hb-chen
Copy link
Contributor

@hb-chen hb-chen commented Apr 17, 2020

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, could you add a test that would fail without this applied? We should have some tests for this local client somewhere.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase the changes on master? It should fix the build error.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johanbrandhorst
Copy link
Collaborator

The bazel error still needs to be fixed manually: https://app.circleci.com/pipelines/github/grpc-ecosystem/grpc-gateway/174/workflows/618ded58-624f-42c6-9852-04d3427e0015/jobs/6796

-- examples/internal/server/BUILD.bazel	1970-01-01 00:00:00.000000000 +0000
+++ examples/internal/server/BUILD.bazel	1970-01-01 00:00:00.000000000 +0000
@@ -19,6 +19,7 @@
         "//examples/internal/proto/examplepb:go_default_library",
         "//examples/internal/proto/sub:go_default_library",
         "//examples/internal/proto/sub2:go_default_library",
+        "//runtime:go_default_library",
         "@com_github_golang_glog//:go_default_library",
         "@com_github_golang_protobuf//proto:go_default_library",
         "@com_github_golang_protobuf//protoc-gen-go/generator:go_default_library_gen",
ERROR: Bazel files out-of-date, please run `bazel run :gazelle`

@johanbrandhorst johanbrandhorst merged commit a56280a into grpc-ecosystem:master Apr 21, 2020
@johanbrandhorst
Copy link
Collaborator

Great work, thanks! Could you please open another PR to merge this to the v2 branch?

@hb-chen hb-chen deleted the fix-query-params branch April 27, 2020 09:21
pull bot pushed a commit to BuildingRobotics/grpc-gateway that referenced this pull request Apr 29, 2020
* template query params bug

* add test case for invoke in process gateway

* fix bazel error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants