Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return if runtime.AnnotateContext gave error #403

Merged
merged 1 commit into from
May 31, 2017
Merged

Return if runtime.AnnotateContext gave error #403

merged 1 commit into from
May 31, 2017

Conversation

tamalsaha
Copy link
Collaborator

Redoing #328

@tamalsaha tamalsaha requested review from tmc and achew22 May 30, 2017 05:58
tmc
tmc approved these changes May 30, 2017
View reviewed changes
Copy link
Collaborator

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase to master?

@tamalsaha
Copy link
Collaborator Author

Rebased. Looks like Go 1.8 test is failing due to x/text package.

@tamalsaha
Copy link
Collaborator Author

cc: @ilius

@tmc tmc merged commit 2a40dd7 into grpc-ecosystem:master May 31, 2017
@tamalsaha tamalsaha deleted the fix-err branch May 31, 2017 02:37
tamalsaha added a commit to gomodules/grpc-gateway that referenced this pull request May 31, 2017
@tamalsaha
Return if runtime.AnnotateContext gave error (grpc-ecosystem#403)
f1d8a17
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
@tamalsaha @tmc
Return if runtime.AnnotateContext gave error (grpc-ecosystem#403)
fcb6329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmc tmc tmc approved these changes

@achew22 achew22 Awaiting requested review from achew22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamalsaha @tmc