fix in protoc-gen-grpc-gateway/gengateway/template.go, #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilius thank you for your contribution -- please regenerate the examples. Also, have you signed the google cla? |
|
@tmc Yes I signed yesterday but haven't received a response yet |
|
|
|
@ilius you need to run and commit the result of 'make examples'. |
|
@ilius can you resolve these conflicts? |
…ime.AnnotateContext gave error don't forget to 'go install' inside protoc-gen-grpc-gateway/
ilius
force-pushed
the
pr2-return-on-error
branch
from
8066fe3
to
4b2a451
Compare
|
I don't know why 'make examples' is not updating examples for me! Even though I removed and re-built and re-installed "protoc-gen-grpc-gateway" many times... |
|
@ilius on my machine if I run 'make realclean test examples' i get exit code 0 and some changed files. |
|
@ilius, did you have any luck regenerating the examples? |
|
Yes but the "return" does not appear in the examples |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return if runtime.AnnotateContext gave error, don't pass to grpc client and don't send request to grpc server
PS: Don't forget to 'go install' inside protoc-gen-grpc-gateway/