Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syllables ending with a hyphen disrupt a translation that follows. #1254

Closed
henryso opened this issue Nov 23, 2016 · 0 comments
Closed

Syllables ending with a hyphen disrupt a translation that follows. #1254

henryso opened this issue Nov 23, 2016 · 0 comments
Assignees
@henryso
Labels
bug C
Milestone
5.0

Comments

@henryso
Copy link
Contributor

henryso commented Nov 23, 2016

A gabc sequence like test-[test](def) will:

  1. truncate the translation to its first character,
  2. append the \GreForceHyphen to the truncated translation, and
  3. cause a memory leak (because the truncated characters are not freed)

Because the code is similar, a similar bug also occurs with auto-protruding characters (,, ., ;, and :).
@henryso henryso added this to the 5.0 milestone Nov 23, 2016
@henryso henryso self-assigned this Nov 23, 2016
henryso added a commit to henryso/gregorio that referenced this issue Nov 23, 2016
@henryso
Fixed truncation/memory leak of translation after a protruding charac…
896fca5 
…ter.

Fixes gregorio-project#1254.
henryso added a commit to henryso/gregorio-test that referenced this issue Nov 23, 2016
@henryso
Added a test for protruding characters against translations.
5b70b6e 
Tests gregorio-project/gregorio#1254 and gregorio-project/gregorio#1255.
henryso added a commit to henryso/gregorio-test that referenced this issue Nov 23, 2016
@henryso
Added a test for protruding characters against translations.
ab8b6f6 
Updated expectations for spurious hyphenation fix.
Tests gregorio-project/gregorio#1254 and gregorio-project/gregorio#1255.
This was referenced Nov 23, 2016
Merged
Merged
@henryso henryso closed this as completed Nov 25, 2016
rpspringuel added a commit that referenced this issue Nov 26, 2016
@rpspringuel
Merge commit '1e32cf0ea5c84ee3561078c501d1b0be2941cf0f' into fix-1029
fbcd4f4 
* commit '1e32cf0ea5c84ee3561078c501d1b0be2941cf0f':
  Prevented \GreForceHyphen from forcing a hyphen in the previous syllable. Fixes #1255.
  Fixed truncation/memory leak of translation after a protruding character. Fixes #1254.
  Removed the shebang from the generated uninstall-gtex.sh file. Removed display of '--no-uninstall', which was inaccurate.
  Made the generated uninstall-gtex.sh TDS-zip-friendly. Fixes #1223.
rpspringuel added a commit to gregorio-project/gregorio-test that referenced this issue Nov 27, 2016
@rpspringuel
Merge commit '4bb387fc8d54c2b4adc2bee49388b5161d0dcf5f' into fix-1029
75a4609 
* commit '4bb387fc8d54c2b4adc2bee49388b5161d0dcf5f':
  Added a test for protruding characters against translations. Updated expectations for spurious hyphenation fix. Tests gregorio-project/gregorio#1254 and gregorio-project/gregorio#1255.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryso henryso

Labels
bug C
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
1 participant
@henryso