Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install uninstall-gtex.sh into texmf tree? #1223

Closed
henryso opened this issue Sep 8, 2016 · 9 comments
Closed

Install uninstall-gtex.sh into texmf tree? #1223

henryso opened this issue Sep 8, 2016 · 9 comments

Comments

@henryso
Copy link
Contributor

henryso commented Sep 8, 2016

Now that I added the code to generate an uninstall manifest (see #1217), should this script be installed into (and therefore also delete itself from) the texmf tree into which it installed GregorioTeX?

This would make the TDS installation different from the command-line installation, but it would seem to be a good place to install the manifest for easier uninstall of GregorioTeX.

If we do this, I presume it would be under scripts/gregoriotex?

@henryso
Copy link
Contributor Author

henryso commented Nov 8, 2016

Any thoughts on this?

@rpspringuel
Copy link
Contributor

I'm not sure what you mean by the installations being different, but I agree that it makes sense to put the uninstall script somewhere on the user's system so that they can find it if they need it.

✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
Br. Samuel, OSB
(R. Padraic Springuel)
PAX ☧ ΧΡΙΣΤΟΣ

On Sep 8, 2016, at 11:30 AM, Henry So notifications@github.com wrote:

Now that I added the code to generate an uninstall manifest (see #1217), should this script be installed into (and therefore also delete itself from) the texmf tree into which it installed GregorioTeX?

This would make the TDS installation different from the command-line installation, but it would seem to be a good place to install the manifest for easier uninstall of GregorioTeX.

If we do this, I presume it would be under scripts/gregoriotex?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@henryso
Copy link
Contributor Author

henryso commented Nov 8, 2016

@rpspringuel What I mean by "different" is that the TDS zip file will not have this uninstall script in it, so it you install by unzipping the TDS zip into an appropriate place, you will not have the uninstall script. You will only get the uninstall script if you install directly using install-gtex.sh.

@rpspringuel
Copy link
Contributor

Is there some reason why we can't include the uninstall script in the TDS file?

✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
Br. Samuel, OSB
(R. Padraic Springuel)
PAX ☧ ΧΡΙΣΤΟΣ

On Nov 8, 2016, at 12:58 PM, Henry So notifications@github.com wrote:

@rpspringuel What I mean by "different" is that the TDS zip file will not have this uninstall script in it, so it you install by unzipping the TDS zip into an appropriate place, you will not have the uninstall script. You will only get the uninstall script if you install directly using install-gtex.sh.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@henryso
Copy link
Contributor Author

henryso commented Nov 8, 2016

It wouldn't make any sense. The paths to the installation are unknown.

@rpspringuel
Copy link
Contributor

Absolute paths, yes. But if the script is inside a TDS structure, then it should know the relative path to other files in the same structure.

✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
Br. Samuel, OSB
(R. Padraic Springuel)
PAX ☧ ΧΡΙΣΤΟΣ

On Nov 8, 2016, at 1:25 PM, Henry So notifications@github.com wrote:

It wouldn't make any sense. The paths to the installation are unknown.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@henryso
Copy link
Contributor Author

henryso commented Nov 8, 2016

If that's how you want it, then the only way I can see that working is to have two different scripts. So it'll still be different, but I guess that's OK?

@rpspringuel
Copy link
Contributor

Why would we need two different scripts? Is there some condition under which the script in the texmf tree (with relative paths) isn't enough and a script outside the texmf tree with absolute paths would be desirable?

I'm not sold on any particular solution at this point, I'm just trying to understand what our options are.

@henryso
Copy link
Contributor Author

henryso commented Nov 9, 2016

The script currently changes to the texmf root (that was passed to install-gtex.sh) and deletes files using relative paths. The script in the TDS zip will need logic to compute the texmf directory from the directory of the script itself rather than using the path passed to install-gtex.sh.

Thinking about it as I type this, I suppose the script can simply always put in this computation logic; then it wouldn't be different. I'll consider this and try to make the changes later this week.

henryso added a commit to henryso/gregorio that referenced this issue Nov 9, 2016
@henryso henryso added this to the 5.0 milestone Nov 9, 2016
@henryso henryso self-assigned this Nov 9, 2016
rpspringuel added a commit that referenced this issue Nov 26, 2016
* commit '1e32cf0ea5c84ee3561078c501d1b0be2941cf0f':
  Prevented \GreForceHyphen from forcing a hyphen in the previous syllable. Fixes #1255.
  Fixed truncation/memory leak of translation after a protruding character. Fixes #1254.
  Removed the shebang from the generated uninstall-gtex.sh file. Removed display of '--no-uninstall', which was inaccurate.
  Made the generated uninstall-gtex.sh TDS-zip-friendly. Fixes #1223.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants