-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install uninstall-gtex.sh into texmf tree? #1223
Comments
Any thoughts on this? |
I'm not sure what you mean by the installations being different, but I agree that it makes sense to put the uninstall script somewhere on the user's system so that they can find it if they need it. ✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
|
@rpspringuel What I mean by "different" is that the TDS zip file will not have this uninstall script in it, so it you install by unzipping the TDS zip into an appropriate place, you will not have the uninstall script. You will only get the uninstall script if you install directly using |
Is there some reason why we can't include the uninstall script in the TDS file? ✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
|
It wouldn't make any sense. The paths to the installation are unknown. |
Absolute paths, yes. But if the script is inside a TDS structure, then it should know the relative path to other files in the same structure. ✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
|
If that's how you want it, then the only way I can see that working is to have two different scripts. So it'll still be different, but I guess that's OK? |
Why would we need two different scripts? Is there some condition under which the script in the texmf tree (with relative paths) isn't enough and a script outside the texmf tree with absolute paths would be desirable? I'm not sold on any particular solution at this point, I'm just trying to understand what our options are. |
The script currently changes to the texmf root (that was passed to Thinking about it as I type this, I suppose the script can simply always put in this computation logic; then it wouldn't be different. I'll consider this and try to make the changes later this week. |
* commit '1e32cf0ea5c84ee3561078c501d1b0be2941cf0f': Prevented \GreForceHyphen from forcing a hyphen in the previous syllable. Fixes #1255. Fixed truncation/memory leak of translation after a protruding character. Fixes #1254. Removed the shebang from the generated uninstall-gtex.sh file. Removed display of '--no-uninstall', which was inaccurate. Made the generated uninstall-gtex.sh TDS-zip-friendly. Fixes #1223.
Now that I added the code to generate an uninstall manifest (see #1217), should this script be installed into (and therefore also delete itself from) the texmf tree into which it installed GregorioTeX?
This would make the TDS installation different from the command-line installation, but it would seem to be a good place to install the manifest for easier uninstall of GregorioTeX.
If we do this, I presume it would be under
scripts/gregoriotex
?The text was updated successfully, but these errors were encountered: