-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect package.json in sub-folders #139
Comments
Hey @leo, thanks for your feature request. It is true that Greenkeeper currently only monitors a package.json at the root of the repository. Thanks for understanding and giving Greenkeeper a try. Best, |
Hi, just a +1 -- I'm not able to use Greenkeeper without this. |
@cjb Awesome! 😊 But: |
+1 to this. It would be great if there were a config var to manually specify other manifest files. I'm using Greenkeeper on the generator portion of angular-fullstack/generator-angular-fullstack, but it would be great if I could also specify our |
@Awk34 Yes, exactly! That would be so awesome for generators and boilerplates in general. |
There's other valid reasons you could face. Other use cases would be projects where you got multiple deploy targets (heroku nodejs apps, react-native and electron apps) where it makes sense to use the same git repo for all the sourcecode. |
@stipsan that reminds be of Babel as well: https://github.com/babel/babel/tree/master/packages (monorepo) |
If you only have one package.json, you can move it to the root and link it from the sub dir (might also work the other way around), then do Edit: Doesn't work the other way around, the actual package.json must be in the root and not the symlink. |
I'd also like to see this feature |
I'm also running into this issue at the moment. |
Suggesting an incremental feature if it could work as a stepping stone... it'll be great if we could initially specify the directory where Background: I work on a project where a single repo contains multiple projects in different languages, and splitting those out to separate repos will incur a whole ton of work on CI config, server config, etc. plus all developers will need to spend a fairly significant amount of time updating their local setup as well... hence we're holding off until this is implemented in some form. |
Greenkeeper looks great, and I'd love to be able to use it in my repo with different python/node subfolders. Let me know if there is anything I can do to help. |
My need is to monitor 2 package.json files within the same repo |
Quoted content from #308, so that it can be closed. |
Proposa here: #594 |
Good news everyone! 🎉 We have just deployed beta support for multiple If you have any trouble with this, or just have a questions please reply here or email support@greenkeeper.io. 📫 Quickstart 🏃♀️Like enabling Greenkeeper for regular repos, adding it to the list of enabled repos in your GitHub App settings page for Greenkeeper will start the multiple-package.json-support. If it is already enabled, you can disable and re-enable it to get started. Alternatively, you can push a valid How it works 🤔We’re in the process of writing proper docs, so this is just a quick reference. 📎 When you enable a repo and Greenkeeper detects that it has multiple {
"groups": {
"default": {
"packages": [
"packages/frontend/package.json",
"packages/backend/package.json"
]
}
}
} Greenkeeper introduces the notion of groups to, well, group different In the case above, there are two Now, given the nature of the project, it might be, that you want to update dependencies differently in the frontend and in the backend. There might even be entirely different teams working on this. In that case, you can update your new {
"groups": {
"frontend": {
"packages": [
"packages/frontend/package.json"
]
},
"backend": {
"packages": [
"packages/backend/package.json"
]
}
}
} With this configuration, you will get separate issues/PRs for the different groups, making the backend and the frontend teams independent of each other. You can have as many groups as you like. There are a few rules for the group names that you can pick and Greenkeeper will open issues with detailed error descriptions, if you introduce errors in your We’d like to thank everyone for their input and patience and we’re looking forward to see how this works for you. 🤗 ❤️ 🌴 PS: We’re now looking at the reverse of this feature: grouping updates that are released from a Monorepo: #711 |
How does this work with lockfiles? And does it work with Yarn Workspaces (where the lockfile for the entire repo is solely in the root)? |
@mAAdhaTTah excellent question. For Greenkeeper, lockfile handling, including yarn, is done in https://github.com/greenkeeperio/greenkeeper-lockfile/ — And we are currently working on getting that updated to support monorepos: greenkeeperio/greenkeeper-lockfile#140 We’ll make sure to make this compatible with yarn workspaces, but no promises yet on when that’s all done. |
Great, I'll subscribe to that PR. Would, in the meantime, manually updating the lockfile in the PR'd branch suffice? |
indeed. |
I switched to Dependabot many months ago. But hey, congratulations on over two full years! I'll un-sub now so you won't have to hear from me again. |
Currently, it seems like greenkeeper only respects the
package.json
within the root directory of a certain repo. If you ask me, it would be awesome if it would also respect all others within in sub-folders.As an example: When building a Yeoman generator, most people add something like a boilerplate which allows developers to easily scaffold the base of their app. And those boilerplates of course also contain a
package.json
(since dependencies need to be installed somehow).The text was updated successfully, but these errors were encountered: