Convert glamorous to styled-components #5 #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update imports
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
=========================================
- Coverage 7.39% 7.38% -0.02%
=========================================
Files 826 826
Lines 26857 26862 +5
Branches 5728 5700 -28
=========================================
- Hits 1986 1983 -3
- Misses 22434 22440 +6
- Partials 2437 2439 +2
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Sep 7, 2018
| @@ -35,6 +35,8 @@ import Layout from 'web/components/layout/layout'; | |||
| const Panel = styled(Layout)` | |||
| background-color: ${Theme.white}; | |||
| border: 1px solid ${Theme.lightBlue}; | |||
| margin-top: 5px; | |||
|
|
|||
There was a problem hiding this comment.
Could you remove the empty line?
When using TimeZoneSelect within a Formgroup together with withLayout(), margins get crazy. For the cost of automatic width adoption (now fixed to 230px, based on the longest string of options) overlapping of TimeZoneSelect with the title of FormGroup is prevented.
Change top and bottom padding from 1px to 4px
swaterkamp
force-pushed
the
glamorous2styledcomponents
branch
from
3a66305
to
1d3f862
Compare
bjoernricks
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #643