Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to other CSS-in-JS library #643

Closed
bjoernricks opened this issue May 9, 2018 · 4 comments · Fixed by #950
Closed

Migrate to other CSS-in-JS library #643

bjoernricks opened this issue May 9, 2018 · 4 comments · Fixed by #950
Assignees
Labels

Comments

@bjoernricks
Copy link
Contributor

It seems glamorous will be deprecated paypal/glamorous#419
So we need to investigate howto migrate to another CSS-in-JS solution like https://emotion.sh/

@bjoernricks bjoernricks self-assigned this May 9, 2018
@bjoernricks bjoernricks changed the title Migrate to emotion Migrate to other CSS-in-JS library May 18, 2018
@bjoernricks
Copy link
Contributor Author

The other possible solution is https://github.com/styled-components/styled-components

@TejasQ
Copy link

TejasQ commented Jun 17, 2018

I wrote a codemod that'll automatically migrate your codebase to emotion. Maybe it could help you? https://github.com/TejasQ/babel-plugin-glamorous-to-emotion

@bjoernricks
Copy link
Contributor Author

Disadvantages of styled-components:

Advantages:

@swaterkamp
Copy link
Member

swaterkamp commented Aug 2, 2018

After some considerations I'd opt for styled-components over emotion. I can't get rid of the feeling that emotion will face the same fate as glamorous after a while, despite it's increasing prevalence. Styled-Components just seems to be the more stable choice and it should be able to provide everything we need one way or the other.

Edit: The decision has been made towards styled-components. Thank you for your suggestion, though, @TejasQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants