Use styled-components for the menu #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, don't use Sticky anymore
Also don't use Sticky anymore
- Re-design the menu's layout - update imports - export StyledMenuEntry to reuse in MenuSection
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=========================================
- Coverage 7.07% 7.07% -0.01%
=========================================
Files 822 822
Lines 26067 26068 +1
Branches 5903 5919 +16
=========================================
Hits 1845 1845
- Misses 21799 21801 +2
+ Partials 2423 2422 -1
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Aug 3, 2018
|
I guess with this PR we can also get rid of sticky.js? |
|
Yes, it will probably be removed in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Menu is changed in design and styled-components is used instead of glamorous.
Some minor fixes are also performed for Badge and logging color as well as translatability for the TitleBar.
This is the first commit regarding issue #643.