Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow results to fill the entire pane horizontally #1142

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix: allow results to fill the entire pane horizontally #1142

merged 1 commit into from
Apr 3, 2020

Conversation

noelleleigh
Copy link
Contributor

Currently, the results pane is limited to a maximum width of 50vw. When the pane is resized (to view long stack trace lines for example), the pane contents don't expand to fill the new space.

This PR fixes that by allowing the results pane to expand to fill the available horizontal space.

Changes proposed in this pull request:

  • Remove the max-width CSS rule for .CodeMirror-scroll.

Screenshots

Before After
Screen Shot showing long lines being wrapped even though there's ample space on the right side to display them unwrapped. Screen Shot showing long lines wrapped to fill the available horizontal space.

Makes it easier to read stack traces.
@CLAassistant
Copy link

CLAassistant commented Mar 30, 2020

CLA assistant check
All committers have signed the CLA.

@noelleleigh noelleleigh changed the title Allow results to fill the entire pane. fix: allow results to fill the entire pane horizontally Mar 30, 2020
@acao
Copy link
Member

acao commented Apr 3, 2020

awesome work! at a quick glance, it seems this is similar to this? #1023 unless I'm mistaken. Either way, I or someone might be able to help get this merged today :)

@noelleleigh
Copy link
Contributor Author

awesome work! at a quick glance, it seems this is similar to this? #1023 unless I'm mistaken. Either way, I or someone might be able to help get this merged today :)

I believe #1023 is trying to solve a different problem. Since it modifies the height properties, I believe both PRs should be compatible.

@acao
Copy link
Member

acao commented Apr 3, 2020

indeed, just reviewed it in netlify and it looks great. Looks good to go! thanks

@acao acao merged commit d418b02 into graphql:master Apr 3, 2020
@acao acao mentioned this pull request Apr 3, 2020
23 tasks
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants