fix: Allow scroll in result panel #1023
Conversation
|
|
|
@httpiago Are you able to sign the CLA |
|
Can confirm that this fixes it, can this please be merged as the div this style should be applied to has no specific class/id, so for now I has to do this: .graphiql-wrapper>div:first-child>div:first-child>div:nth-child(2)>div:nth-child(2) {
height: 100%
} |
|
Can someone approve this so it can be merged, please? Currently working with subscriptions in Playground is a bit boring... |
|
animated GIF (scrolling the result panel.) |
|
It would be nice to scroll to the bottom on new subscription data too :) |
The behavior like many terminal windows have it would be great. |
|
When will this change be merged in? I'm experiencing this issue right now and wondering why a one-line change has been sitting around for such a long time. Without it subscriptions are broken in the playground. |
There was a problem hiding this comment.
This solution solves 2 issues:
- It allows the entire events feed to be scrollable
- It prevents the bottom area of UI from disappearing once the content's height is greater than the viewport's height
It's worth evaluating whether the event's codemirror container needs to be scrollable, given the fact that the code inside is collapsible
|
can we merge this please? I think this is not difficult |
|
there are 5 reviewers here, please accept this PR sir |
|
I have this problem too. Is there any reason this is being held up? |
|
This bug makes it look like the subscription panel is broken, and makes it unusable. Please merge this in! |
|
I hate bothering people who put so much effort into open source work but this is a major sore spot and having a three liner sit for six months is frankly not a good look. @chdanielmueller @JordanBCX @borrascador @avernikoz @Jdender @Tahir500 |
|
Any update on this? We really really need this in! |
|
@chdanielmueller @JordanBCX @borrascador @avernikoz @Jdender @Tahir500 @iagobruno Can this be merged please, the playground is unusable when using subscriptions. |
|
@NathHorrigan Someone with write access to the repo needs to approve the PR before it can be merged. Someone like @huv1k or @timsuchanek |
|
can somebody please merge this? This lowing hanging fruit will bring much value 💯 |
|
Omg, can't believe this is STILL not merged :( |
|
We will merge this PR fix and a few other bugfixes before #1143 happens, FYI. Expect a release in a week or two, if not less. Thanks for your patience everyone! |
|
May 5, 2019 it been almost one year. Is it too hard? or you too busy to take some time to merge this? I just dissapoint. We bet so much on this technology. We have try prisma with new project. and we have to abandon it because such a small thing make us slow. this is not just only one. You have to improve it from small thing to big thing. |
|
@hiepxanh hello, i just got access to this repository a day or two ago, was never a contributor before, also I don't represent Prisma, either. You may want to read this article about the future of prisma's support for open source graphql projects: https://www.prisma.io/blog/the-guild-takes-over-oss-libraries-vvluy2i4uevs/ or this announcement here: either way, there should be a release today that fixes this, will let folks know when it's released! |
|
Glad it's finally merged!!! Thanks @acao |
|
Thanks @acao for merging this very much needed PR and I wish you the best of luck maintaining this repo! Thank you again!! |
|
thanks @acao you are a new comer. Good job. Thank you so much |
|
glad to help! see releases for this and others for -react, -html, and the express middleware, working on testing the rest now (hapi, lambda, koa, etc) |
* Limit the height of the result panel to the max size * Pin scrollbar position in the subscription result pane
* Limit the height of the result panel to the max size * Pin scrollbar position in the subscription result pane
Currently is not possible to see all the events of a subscription in the results pane for lack of a css property, this pull request fix #1021 this.