Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-service detailed query logs #428

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman commented Jun 8, 2022

The goal is to enable monitoring of the fees paid for queries.

The change adds detailed query logs for paid queries w/:

Deployment (base58 IPFS hash)
Query execution time
GQL query / variables
GRT fees
Note that to add the GQL query response time measurement to Axios as recommended in the documentation, I had to do some non-TSisms. Hopefully there is a better way to do that.

@aasseman aasseman force-pushed the alexis/indexer-service-query-logs branch from 65876d8 to 691f486 Compare June 8, 2022 03:14
@aasseman
Copy link
Contributor Author

aasseman commented Jun 23, 2022

I had to do some non-TSisms.

That should be fixed now.

@aasseman aasseman force-pushed the alexis/indexer-service-query-logs branch from ba8cda6 to 22c9e77 Compare June 23, 2022 02:08
@aasseman aasseman marked this pull request as ready for review June 23, 2022 02:22
@aasseman aasseman requested a review from fordN June 23, 2022 02:22
@aasseman aasseman closed this Jun 29, 2022
@aasseman aasseman deleted the alexis/indexer-service-query-logs branch June 29, 2022 01:08
@aasseman aasseman restored the alexis/indexer-service-query-logs branch June 29, 2022 01:17
@aasseman aasseman reopened this Jun 29, 2022
@aasseman
Copy link
Contributor Author

Sorry for the close, not sure what happened there :/

@aasseman
Copy link
Contributor Author

Tested on a rebase of those changes onto v0.19.3 on our mainnet indexer. No issues.

@aasseman aasseman force-pushed the alexis/indexer-service-query-logs branch from 1389537 to c237da2 Compare July 19, 2022 17:51
@aasseman
Copy link
Contributor Author

Rebased onto main + squashed my commits

@fordN fordN force-pushed the alexis/indexer-service-query-logs branch from c237da2 to ccb5ff8 Compare July 19, 2022 18:52
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aasseman aasseman merged commit 3942c4c into main Jul 19, 2022
@aasseman aasseman deleted the alexis/indexer-service-query-logs branch July 19, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants