Typescriptify Axios request time interceptors

graphprotocol · Jun 23, 2022 · ba8cda6 · ba8cda6
1 parent 691f486
commit ba8cda6
Showing 1 changed file with 20 additions and 7 deletions.
diff --git a/packages/indexer-service/src/queries.ts b/packages/indexer-service/src/queries.ts
@@ -1,4 +1,4 @@
-import axios, { AxiosInstance, AxiosResponse } from 'axios'
+import axios, { AxiosInstance, AxiosResponse, AxiosRequestConfig } from 'axios'
 
 import { Logger, Metrics, Eventual } from '@graphprotocol/common-ts'
 import {
@@ -20,6 +20,15 @@ export interface PaidQueryProcessorOptions {
   receiptManager: ReceiptManager
 }
 
+interface AxiosRequestConfigWithTime extends AxiosRequestConfig {
+  meta?: { requestStartedAt?: number }
+}
+
+interface AxiosResponseWithTime extends AxiosResponse {
+  responseTime?: number
+  config: AxiosRequestConfigWithTime
+}
+
 export class QueryProcessor implements QueryProcessorInterface {
   logger: Logger
   metrics: Metrics
@@ -54,21 +63,25 @@ export class QueryProcessor implements QueryProcessorInterface {
 
     // Set up Axios for request response time measurement
     // https://sabljakovich.medium.com/axios-response-time-capture-and-log-8ff54a02275d
-    this.graphNode.interceptors.request.use(function (x: any) {
+    this.graphNode.interceptors.request.use(function (x: AxiosRequestConfigWithTime) {
       // to avoid overwriting if another interceptor
       // already defined the same object (meta)
       x.meta = x.meta || {}
       x.meta.requestStartedAt = new Date().getTime()
       return x
     })
     this.graphNode.interceptors.response.use(
-      function (x: any) {
-        x.responseTime = new Date().getTime() - x.config.meta.requestStartedAt
+      function (x: AxiosResponseWithTime) {
+        if (x.config.meta?.requestStartedAt !== undefined) {
+          x.responseTime = new Date().getTime() - x.config.meta?.requestStartedAt
+        }
         return x
       },
       // Handle 4xx & 5xx responses
-      function (x: any) {
-        x.responseTime = new Date().getTime() - x.config.meta.requestStartedAt
+      function (x: AxiosResponseWithTime) {
+        if (x.config.meta?.requestStartedAt !== undefined) {
+          x.responseTime = new Date().getTime() - x.config.meta.requestStartedAt
+        }
         throw x
       },
     )
@@ -134,7 +147,7 @@ export class QueryProcessor implements QueryProcessorInterface {
       deployment: subgraphDeploymentID.ipfsHash,
       fees: parsedReceipt.fees.toBigInt().toString(),
       query: query,
-      responseTime: (response as any).responseTime,
+      responseTime: (response as AxiosResponseWithTime).responseTime ?? null,
     })
 
     return {