New default geb feature implementation
#413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename feature `geb` to `geb-with-webdriver-binaries` and make it an optional feature - Add new default feature `geb-with-testcontainers`
Because tests are timing out
This reverts commit f72c669.
|
The build is failing right now when running tests. mattias@mattias-z4-linux:/tmp/grailsforgetmp15664837821511079914$ ./gradlew build
FAILURE: Build failed with an exception.
* What went wrong:
Could not resolve all files for configuration ':buildSrc:buildScriptClasspath'.
> Could not resolve org.apache.groovy:groovy:4.0.24-SNAPSHOT.
Required by:
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118 > org.apache.groovy:groovy-ant:4.0.23
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118 > org.apache.groovy:groovy-json:4.0.23
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118 > org.apache.groovy:groovy-jmx:4.0.23
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118 > org.apache.groovy:groovy-xml:4.0.23
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118 > org.apache.groovy:groovy-bom:4.0.23
> Could not resolve org.apache.groovy:groovy:4.0.24-SNAPSHOT.
> Could not get resource 'https://repo.grails.org/grails/core/org/apache/groovy/groovy/4.0.24-SNAPSHOT/groovy-4.0.24-SNAPSHOT.pom'.
> Could not GET 'https://repo.grails.org/grails/core/org/apache/groovy/groovy/4.0.24-SNAPSHOT/groovy-4.0.24-SNAPSHOT.pom'.
> Read timed out
> Could not resolve org.grails:grails-datastore-core:9.0.0-SNAPSHOT.
Required by:
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22 > org.grails:grails-datastore-web:9.0.0-SNAPSHOT:20241025.200433-19
> Skipped due to earlier error
> Could not resolve org.grails:grails-datastore-gorm:9.0.0-SNAPSHOT.
Required by:
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22 > org.grails:grails-datastore-gorm-support:9.0.0-SNAPSHOT:20241025.200433-19
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22 > org.grails:grails-datastore-gorm-hibernate5:9.0.0-SNAPSHOT:20241026.013223-23
> Skipped due to earlier error
> Could not resolve org.grails:grails-core:7.0.0-SNAPSHOT.
Required by:
project :buildSrc > org.grails:grails-bom:7.0.0-SNAPSHOT:20241024.195419-118
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22 > org.grails:grails-datastore-gorm-support:9.0.0-SNAPSHOT:20241025.200433-19
> Skipped due to earlier error
> Could not resolve org.apache.groovy:groovy:4.0.24-SNAPSHOT.
Required by:
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22 > org.grails:grails-datastore-web:9.0.0-SNAPSHOT:20241025.200433-19
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22 > org.grails:grails-datastore-gorm-support:9.0.0-SNAPSHOT:20241025.200433-19
project :buildSrc > org.grails.plugins:hibernate5:9.0.0-SNAPSHOT:20241026.013223-22 > org.grails:grails-datastore-gorm-hibernate5:9.0.0-SNAPSHOT:20241026.013223-23
> Could not resolve org.apache.groovy:groovy:4.0.24-SNAPSHOT.
> Could not get resource 'https://repo.grails.org/grails/core/org/apache/groovy/groovy/4.0.24-SNAPSHOT/groovy-4.0.24-SNAPSHOT.pom'.
> Could not GET 'https://repo.grails.org/grails/core/org/apache/groovy/groovy/4.0.24-SNAPSHOT/groovy-4.0.24-SNAPSHOT.pom'.
> Read timed out
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
BUILD FAILED in 2m 24s
1 actionable task: 1 up-to-date |
| @@ -47,7 +47,7 @@ class CommandSpec extends Specification { | |||
| Process executeGradleCommand(String command) { | |||
| StringBuilder gradleCommand = new StringBuilder() | |||
| if (spock.util.environment.OperatingSystem.current.isWindows()) { | |||
| gradleCommand.append("gradlew.bat") | |||
| gradleCommand.append("cmd.exe /c gradlew") | |||
There was a problem hiding this comment.
Thank you for finding this solution!
jamesfredley
approved these changes
Oct 28, 2024
|
geb-with-testcontainers should allow Gradle to go back to 8.10.2. geb-with-webdriver-binaries will be stuck at 8.6, for now. |
After switching to `ContainerGebSpec`, it is no longer necessary to have the integration tests disabled. Related: #385
@jamesfredley Is it possible to differentiate the gradle version based on selected features? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gebtogeb-with-webdriver-binariesand make it an optional featuregeb-with-testcontainers