Include Geb/Selenium dependencies for MacOS Arch64 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already enabled in another part of the code in ad660a5 It looks like this was missed.
jamesfredley
approved these changes
Oct 7, 2024
matrei
changed the title
Due to an issue with the integrationTest task during the create-app tests, the task is being temporarily disabled. The tests fail with `org.openqa.selenium.SessionNotCreatedException`, which seems to be related to the inclusion of Geb/Selenium dependencies for `OperatingSystem.MACOS_ARCH64`. The apps in the create-app tests are created with `OperatingSystem.MACOS_ARCH64` as the operating system parameter, but will fail also for other operating systems. This issue was likely masked before commit 8675723, when the Geb/Selenium dependencies were not included for MACOS_ARCH64. With the dependencies now included, the integrationTest task fails.
jamesfredley
approved these changes
Oct 8, 2024
test-core/src/test/groovy/org/grails/forge/create/CreateAppSpec.groovy
Outdated
Show resolved
Hide resolved
jamesfredley
added a commit
that referenced
this pull request
Oct 9, 2024
* Add grails-app/conf/spring/resources.groovy as a default feature (#366) * Add grails-app/conf/spring/resources.groovy as a default feature to align with pre Grails 6 versions * Set "executable" flag on grailsw * Update to grails wrapper 4.0.1 - includes update-wrapper command for Grails 6 (#375) * prep for grails 6.2.1 release (#376) * [skip ci] Release v6.2.1 * chore: Bump version to 6.2.2-SNAPSHOT * update grails-core to 6.2.2-SNAPSHOT (#379) * update grails-core 6.2.2-SNAPSHOT * Use Java 11 in 6.2.x branch (#382) * ci: Use Java 11 in 6.2.x branch If native image is built with Java 17, application created with it will not be compatible with Java 11. Error: LinkageError occurred while loading main class g621app.Application java.lang.UnsupportedClassVersionError: g621app/Application has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 * ci: graalvm +version -distribution Test tip from graalvm/setup-graalvm#105 (comment) * ci: Disable OSX Arm Native CLI Graalvm cannot build Java 11 OSX Arm Native Image Error: Failed to download graalvm-ce-java11-darwin-aarch64-22.3.3. Are you sure version: '22.3.3' and java-version: '11' are correct? * Include Geb/Selenium dependencies for MacOS Arch64 (#385) * fix: Enable inclusion of Geb/Selenium deps for Macos Arch64 This was already enabled in another part of the code in ad660a5 It looks like this was missed. * test: Temporarily disable integrationTest task in create-app specs Due to an issue with the integrationTest task during the create-app tests, the task is being temporarily disabled. The tests fail with `org.openqa.selenium.SessionNotCreatedException`, which seems to be related to the inclusion of Geb/Selenium dependencies for `OperatingSystem.MACOS_ARCH64`. The apps in the create-app tests are created with `OperatingSystem.MACOS_ARCH64` as the operating system parameter, but will fail also for other operating systems. This issue was likely masked before commit 8675723, when the Geb/Selenium dependencies were not included for MACOS_ARCH64. With the dependencies now included, the integrationTest task fails. --------- Co-authored-by: Scott Murphy <scott@alwaysvip.com> Co-authored-by: grails-build <grails-build@users.noreply.github.com> Co-authored-by: Mattias Reichel <mattias.reichel@gmail.com>
matrei
added a commit
that referenced
this pull request
Oct 28, 2024
After switching to `ContainerGebSpec`, it is no longer necessary to have the integration tests disabled. Related: #385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion of Geb/Selenium dependencies for MacOS Arch64 was already addressed in commit ad660a5, but this specific part appears to have been missed.