-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with Node 15 #225
Comments
Oh, looks like there's a PR already: #224 |
Is this a warning or hard blocker? We don't test with odd versions of Node right now. And if we don't test it, we're not going to ship supposed support for it. If this is a blocking hard error (e.g. Actually latest odd version might be a good idea in general. WDTY? |
The last (odd or not) version would be a good idea yes. BTW, 14 still isn't LTS (only starting next week), and afaict the only odd/even rule is that only even releases eventually become LTS, but 14 wasn't (and technically still isn't) any different from 13 or 15. |
I realize I didn't answer your first question:
It's a hard blocker.
(emphasis mine) And to backup my previous comment, if you want to be selective about what versions of Node you support (and ban other versions from using your lib), then you should at a minimum list the Maintenance LTS (if you choose to support it; currently 10, both 10 and 12 starting next Friday), the Active LTS (currently 12, both 12 and 14 starting next Tuesday, and 14 only starting next Friday), the Current (currently both 14 and 15, only 15 starting next Tuesday when 14 switches to Active LTS), and the Pending (currently 16, was 15 just a few days ago) to be future-proof (that would have allowed 3.2.0 to run on Node 15; then maybe there are incompatibilities, but at least we're in a situation where we can actually discover them, rather than being banned from using the library) If you ask me, I would totally remove the Fwiw, our CI builds our client apps with the |
Yep I agree with you @tbroyer. |
Node 15 has arrived to Arch (https://www.archlinux.org/packages/?q=nodejs), it'd be awesome if you could cut a release with the recent changes to the |
Thanks a lot for your reactivity! |
The text was updated successfully, but these errors were encountered: