Skip to content

Commit

Permalink
feat: do not enforce node version (#226)
Browse files Browse the repository at this point in the history
closes #225
  • Loading branch information
Jason Kuhrt authored Oct 25, 2020
1 parent d371b54 commit 37b51e1
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
name: trunk
name: pr

on:
pull_request:
branches: [master]
pull_request: {}

jobs:
tests:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10.x, 12.x, 14.x]
node: [10.x, 12.x, 14.x, 15.x]
environment: [dom, node]
name: Node ${{ matrix.node }}
name: Node ${{ matrix.node }} @env ${{matrix.environment}}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trunk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10.x, 12.x, 14.x]
node: [10.x, 12.x, 14.x, 15.x]
environment: [dom, node]
name: Node ${{ matrix.node }}
steps:
Expand Down
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ const client = new GraphQLClient(endpoint, { headers: {} })
client.request(query, variables).then((data) => console.log(data))
```

## Node Version Support

We only officially support [LTS Node versions](https://github.com/nodejs/Release#release-schedule). We also make an effort to support two additional versions:

1. The latest even Node version if it is not LTS already.
2. The odd Node version directly following the latest even version.

You are free to try using other versions of Node (e.g. `13.x`) with `graphql-request` but at your own risk.

## Examples

### Authentication via HTTP header
Expand Down
3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
"bugs": {
"url": "https://github.com/prisma/graphql-request/issues"
},
"engines": {
"node": "10.x || 12.x || 14.x"
},
"homepage": "https://github.com/prisma/graphql-request",
"scripts": {
"dev": "rm -rf dist && tsc --watch",
Expand Down

0 comments on commit 37b51e1

Please sign in to comment.