Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ingester request minimisation for other query APIs #5263

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jun 16, 2023

What this PR does

This PR adds support for request minimisation (aka "make requests to only two of three ingester zones to start with") for other query APIs:

  • LabelNames
  • LabelValuesForLabelName
  • LabelNamesAndValues
  • MetricsForLabelMatchers
  • MetricsMetadata
  • QueryExemplars

Which issue(s) this PR fixes or relates to

Relates to #5202

Checklist

  • Tests updated
  • [n/a] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@charleskorn charleskorn marked this pull request as ready for review June 16, 2023 05:49
@charleskorn charleskorn requested a review from a team as a code owner June 16, 2023 05:49
@pracucci pracucci self-requested a review June 16, 2023 14:40
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, LGTM! Thanks for adding missing tests.

@pracucci pracucci merged commit e4d5826 into main Jun 16, 2023
@pracucci pracucci deleted the charleskorn/request-minimisation-for-other-query-apis branch June 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants